Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Improve DioException.requestOptions explanation when it's empty #1960

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

AlexV525
Copy link
Member

Address #1943 (comment).

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

After some investigation, I think there are two other ways we can resolve this:

  1. Apply the latest request options in each interceptor handler, because the options can be modified in any of them.
  2. Treat the field as nullable, but this may be worse and I remember that we tried once without any good results.

@AlexV525 AlexV525 requested a review from a team as a code owner September 11, 2023 03:49
@ueman ueman added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 90619eb Sep 11, 2023
@ueman ueman deleted the chore/dio-exception-request-options-doc branch September 11, 2023 14:29
@AlexV525 AlexV525 added e: documentation Improvements or additions to documentation p: dio Targeting `dio` package labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: documentation Improvements or additions to documentation p: dio Targeting `dio` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants